[Xfce-bugs] [Bug 16763] patch for xfce-shortcuts-grabber.c which wrongly ungrabs keys when updating grabbed ones

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16763

Jethro Nederhof <jethro at jethron.id.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jethro at jethron.id.au

--- Comment #17 from Jethro Nederhof <jethro at jethron.id.au> ---
Hi @Simon,

The bug is more generic than just breaking the Up arrow, but the Up arrow is
the most noticable symptom.
You can simulate the Up arrow situation that shows the cleanup problem by
starting XFCE and running something like this:

```
# enable default XFCE keyboard shortcuts in Settings > Keyboard > Application
Shortcuts > Reset to Defaults
# set 'Up' to 'Print' like in the intial keymap for some people (for some
reason)
xmodmap -e "keysym Up = Print"
# pressing Up should now launch xfce screen grabber
# this is the wrong keymap! reset to something sane (not sure what triggers
this correction for people with the problem, but it seems to happen
automatically on first keypress)
setxkbmap -model pc105 # or whatever your default was
# pressing Up should no longer launch xfce screen grabber
# but it also will not send Up to your terminal or any other application,
because XFCE didn't ungrab it
# that application will 'flash' as the root window takes focus, does nothing
because the keypress matched no shortcuts, restores focus to your application
```

Doing the above with this patch:
```
# enable default XFCE keyboard shortcuts in Settings > Keyboard > Application
Shortcuts > Reset to Defaults
# set 'Up' to 'Print' like in the intial keymap for some people (for some
reason)
xmodmap -e "keysym Up = Print"
# pressing Up should now launch xfce screen grabber
# this is the wrong keymap! reset to something sane (not sure what triggers
this correction for people with the problem, but it seems to happen
automatically on first keypress)
setxkbmap -model pc105 # or whatever your default was
# pressing Up should no longer launch xfce screen grabber
# Up correctly registers in your terminal and previous command is displayed or
whatever your shell does with Up
```

Since it's fixed downstream on FreeBSD already with this patch, I spun up a
Debian VM I have (Bullseye/sid, but should be replicable on more stable
versions or your test container, too) and the behaviour is as above with xfce4
4.14.

Hope this helps, let me know if I can do anything to give your more info.

-- 
You are receiving this mail because:
You are the assignee for the bug.