[Xfce-bugs] [Bug 16849] New: reserved identifier violation

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16849

            Bug ID: 16849
           Summary: reserved identifier violation
    Classification: Xfce Core
           Product: Xfconf
           Version: 4.14.1
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: xfce-bugs at xfce.org
          Reporter: elfring at users.sourceforge.net
  Target Milestone: Future

I would like to point out that identifiers like “__XFCONF_H__” and
“_XfconfDaemon” do not fit to the expected naming convention of the C language
standard.
*
https://gitlab.xfce.org/xfce/xfconf/-/blob/9ec67fb671b488a81f837e9127719b0bf5027624/xfconf/xfconf.h#L21
*
https://gitlab.xfce.org/xfce/xfconf/-/blob/9ec67fb671b488a81f837e9127719b0bf5027624/xfconfd/xfconf-daemon.h#L35

Would you like to adjust the selection for unique names?
https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

-- 
You are receiving this mail because:
You are the assignee for the bug.