[Xfce-bugs] [Bug 16566] Improve tooltips in shortcuts view

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16566

alexxcons <alexxcons at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexxcons at xfce.org

--- Comment #1 from alexxcons <alexxcons at xfce.org> ---
Nice little features !

These suggestions are all fine for me.

First I thought it would be nice to have more consitency, by showing the path
for all locations in the first line, and some additional info in the second
line.
Though I guess that might be to much irrelevant text for the standard folders.

In the code, I would rename "device_string" to tooltip.

Another small thing:

              device_location = g_file_get_uri (file);
              device_string = g_strdup_printf ("%s", device_location);

              g_value_take_string (value, device_string);

              g_free (device_location);

Why not directly g_value_take_string (value, g_file_get_uri (file)); ?

-- 
You are receiving this mail because:
You are the assignee for the bug.