[Xfce-bugs] [Bug 16024] The side pane tree navigation is disrupted and is very disorienting when a mounted partition folder is clicked on.

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16024

--- Comment #9 from alexxcons <alexxcons at xfce.org> ---
(In reply to Theo Linkspfeifer from comment #8)
> > // check if path valid?
> I guess I wanted to check for a NULL pointer afterwards.
ok .. think not needed here, since according to the doc, "gtk_tree_path_up"
only does something if there is a parent.

> > I moved the logic to free path directly into the innermost "if", so that "keep_path" isnot required.
> If the previous checks fail, path should be freed also.
Ok, I missed that one .. so lets rather use your diff as a base than my patch

> Other than that, I thought about making this new block a new function (like
> thunar_tree_view_get_preferred_toplevel_path() does). Bad idea?
Good point ! Think I would just move the code-block  to
"thunar_tree_view_get_preferred_toplevel_path" .. that function-name already
fits the purpose of the code-block.

-- 
You are receiving this mail because:
You are the assignee for the bug.