[Xfce-bugs] [Bug 16516] Move network to the bottom of tree view

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16516

--- Comment #7 from alexxcons <alexxcons at xfce.org> ---
Works fine here, thanks !

> if (thunar_device_sort (item->device, device) > 0)
You switched from "lesss than" to "greater than" for a special reason ?

  for (node2 = node->next; node2 != NULL; node2 = node2->next)
    {
      item = THUNAR_TREE_MODEL_ITEM (node2->data);
      if (item->device == NULL)
        break;

      /* sort devices by timestamp */
      if (thunar_device_sort (item->device, device) > 0)
        break;

      node = node2;
  }

Think that loop can be done with only one "node" variable:

  /* determine the position for the new node in the item list */
  for (;node->next != NULL; node = node->next)
    {
      item = THUNAR_TREE_MODEL_ITEM (node->data);
      if (item->device == NULL)
        break;

      /* sort devices by timestamp */
      if (thunar_device_sort (item->device, device) > 0)
        break;
    }

... or do I miss something ?

-- 
You are receiving this mail because:
You are the assignee for the bug.