[Xfce-bugs] [Bug 15172] Clicking on MTP device in tree-view crashes Thunar

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15172

--- Comment #34 from alexxcons <alexxcons at xfce.org> ---
(In reply to Theo Linkspfeifer from comment #31)
> The proposed fix reverts this commit:
> https://git.xfce.org/xfce/thunar/commit/
> ?id=33a155c1bded0487396b609aad19730a9f201bbb

Gna ... actually the code looked familar, so I tried the following:
git blame thunar-tree-model.c -L :thunar_tree_model_device_added
... looks like I failed to use git blame :F  .. how did you find the commit ?

(In reply to Reuben Green from comment #32)
> Alex, can you remember the details of the bug (bug #14960) you were trying
> to fix with that commit? It's probably not a good idea to bring back that
> bug by fixing this one, so maybe we should look into it before we try to do
> anything more?
Sorry, I dont remeber ... I should have added more details when I worked on it.

The bug  mentioned that the freeze happened only rarely. I would suggest to
push your patch and we all test the fixed thunar master for a few days. If
nobody investigates a freeze, I would do a release. You think that sounds
reasonable ?

(In reply to fuank from comment #33)
> Thanks Reuben Green. I've tested the patch and it seems to fix the problem
> as I reported in https://bugzilla.xfce.org/show_bug.cgi?id=15972
Thanks alot for testing! (And sorry for causing you all the  trouble with my
old fix)

-- 
You are receiving this mail because:
You are the assignee for the bug.