[Xfce-bugs] [Bug 16542] Add a new widget for filename input

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16542

alexxcons <alexxcons at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexxcons at xfce.org

--- Comment #2 from alexxcons <alexxcons at xfce.org> ---
Created attachment 9588
  --> https://bugzilla.xfce.org/attachment.cgi?id=9588&action=edit
formatting patch

Nice, thanks alot for the patch !

Here some remarks:
- I applied some formatting ... see first patch attached
- There are two build warnings to be fixed "comparison of integer expressions
of different signedness"
- All methods which are public API should get documentation in the *.c file
--  Use the following in the comments: "* Return value: (transfer none):
blabla"  in order to get rid of the build warning
"xfce_filename_input_get_entry: return value: Missing (transfer) annotation"
--
(https://gi.readthedocs.io/en/latest/annotations/giannotations.html#memory-and-lifecycle-management)

- There is a "tests" folder in the project .. I did not try, though I guess you
can put the code of the demonstrator there
- Attached another patch which keeps the public API a bit smaller by using
properties  .. like that you can create the filename_input with:
g_object_new (XFCE_TYPE_FILENAME_INPUT,  "original-file-name", orig_name,
"max-length", max_len, NULL);

.... for some reason I dont understand, yet, I cannot test my changes with your
demonstrator .. please feel free to test my patches (I only know that it
compiles) and merge them into your patch, if you think it is apropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.