[Xfce-bugs] [Bug 16389] New: Thunar righ-click menu has a serious drawback that must be corrected

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Fri Jan 17 07:33:01 CET 2020


https://bugzilla.xfce.org/show_bug.cgi?id=16389

            Bug ID: 16389
           Summary: Thunar righ-click menu has a serious drawback that
                    must be corrected
    Classification: Xfce Core
           Product: Thunar
           Version: unspecified
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: xfce-bugs at xfce.org
          Reporter: ersrpca001 at hotmail.com
  Target Milestone: 1.8.12

Before I write this bug, I have searched for help on XFCE Forum, where I
created this topic searching for help:
https://forum.xfce.org/viewtopic.php?id=13681

After some replies, I open this bug report as sugested by the forum moderator
ToZ in this reply to the same topic here:
https://forum.xfce.org/viewtopic.php?pid=56124#p56124

Because of time constraints, I am going to explain the bug using copy-paste
from that forum post.
This is a bit long, but it explains rather well the situation and also there
are links to screenshots that are very ilustrative.

=============================================
jack_the_pirate 
2020-01-14 09:45:40 WET

IMHO the default XFCE file manager (Thunar) righ-click menu has a serious
drawback that must be corrected:

- when the mouse right-click is used, the right-click menu appears

- and an entry (command) of that menu is already automatically selected by
default

- this is very bad because if you inadvertedly press left-click or right-click
again, that command is going to run

This has happened to me several times, some without serious consequences, and
some more serious.

Also, the problem is more difficult to solve because the automatically selected
menu entry changes when the right-click is done near the edges ot the screen,
especially the bottom.

And it can be much worse if you are like me and have many Thunar custom-actions
that make the right-click menu very big.

For example, I have a custom-action with a script that moves the selected
file(s) or folder(s) to a specific folder.
When I right-clicked a Virtualbox VDI file to copy it, I inadvertedly pressed
right-click again and it was being copied to that folder and I had to restart
immediately my computer to stop it.
I know this was my fault, but it never would happen with another file manager
because the second right-click would do nothing when pressed.
The same has happened multiple times to me, but with minor files or folders.

At first, I thought it was my fault for inadvertedly pressing left-click or
right-click again.

But now I think it is really a problem of Thunar's design for the motive that
this does doesn't happen with other file managers.

Also, I remember reading someone in another forum complaining about Thunar
because of this precise situation, and that was when I started paying attention
to this more seriously as a Thunar bad feature.

Today, before writing this post, I've tested various operative systems I have
in various Virtualbox machines, and only Thunar has this dangerous behaviour:
- Debian 9 XFCE
- Debian 10 XFCE
- CentOS 7 (CentOS doesn't have a XFCE version, but I installed it)

This does NOT happen with:
- Linux with file manager PC Man FM
- Linux with MATE default file manager (can't remember the name, but I've
tested it)
- Linux with Gnome Classic default file manager (can't remember the name, but
I've tested it)
- Windows (all versions: Vista, 7, 10, etc) with file manager Explorer

Because this is so serious, I am goig to repeat it:
- this only happens in Thunar
- does doesn't happen with other file managers
- is everybody wrong, but Thunar?...

Lastly, I would like to know if someone knows how to change this in Thunar.

Last edited by jack_the_pirate (2020-01-14 09:47:25)

=============================================
ToZ
2020-01-14 12:39:07

Exactly what versions of Xfce and thunar are you running that this is happening
with?

This is the second report in a week about this issue (see also:
https://forum.xfce.org/viewtopic.php?id=13662). I can't replicate this on any
of my systems (4.12 or 4.14 with numerous different versions of thunar), but
given that multiple people are seeing the issue, I think its time to create a
bug report and see what the developer can determine.

I'll give debian another run in a VM to see if I can replicate it there.

Edit: Which GTK (Appearance) and Window Manager themes are you using? Or:

xfconf-query -c xsettings -lv

Last edited by ToZ (2020-01-14 14:55:31)

=============================================
jack_the_pirate 
2020-01-15 10:56:51

Here is the info:

*********************************************
Debian 9 XFCE
Thunar 1.6.11
Xfce 4.12

$ xfconf-query -c xsettings -lv
/Gtk/ButtonImages               true
/Gtk/CanChangeAccels            false
/Gtk/ColorPalette               black:white:gray50:red:purple:blue:light
blue:green:yellow:orange:lavender:brown:goldenrod4:dodger blue:pink:light
green:gray10:gray30:gray75:gray90
/Gtk/CursorThemeName            Classic-Flat-White
/Gtk/CursorThemeSize            0
/Gtk/DecorationLayout           menu:minimize,maximize,close
/Gtk/FontName                   Sans 10
/Gtk/IconSizes                 
/Gtk/KeyThemeName               
/Gtk/MenuBarAccel               F10
/Gtk/MenuImages                 true
/Gtk/ToolbarIconSize            3
/Gtk/ToolbarStyle               icons
/Net/CursorBlink                true
/Net/CursorBlinkTime            1200
/Net/DndDragThreshold           8
/Net/DoubleClickDistance        5
/Net/DoubleClickTime            400
/Net/EnableEventSounds          false
/Net/EnableInputFeedbackSounds  false
/Net/IconThemeName              Tango
/Net/SoundThemeName             default
/Net/ThemeName                  Xfce-basic
/Xft/Antialias                  1
/Xft/Hinting                    1
/Xft/HintStyle                  hintslight
/Xft/RGBA                       none

*********************************************
Debian 10 XFCE - DOES have the issue
Thunar 1.8.4
Xfce 4.12

$ xfconf-query -c xsettings -lv
/Gtk/ButtonImages               true
/Gtk/CanChangeAccels            false
/Gtk/ColorPalette               black:white:gray50:red:purple:blue:light
blue:green:yellow:orange:lavender:brown:goldenrod4:dodger blue:pink:light
green:gray10:gray30:gray75:gray90
/Gtk/CursorThemeName           
/Gtk/CursorThemeSize            0
/Gtk/DecorationLayout           menu:minimize,maximize,close
/Gtk/FontName                   Sans 10
/Gtk/IconSizes                 
/Gtk/KeyThemeName               
/Gtk/MenuBarAccel               F10
/Gtk/MenuImages                 true
/Gtk/MonospaceFontName          Monospace 10
/Gtk/ToolbarIconSize            3
/Gtk/ToolbarStyle               icons
/Net/CursorBlink                true
/Net/CursorBlinkTime            1200
/Net/DndDragThreshold           8
/Net/DoubleClickDistance        5
/Net/DoubleClickTime            400
/Net/EnableEventSounds          false
/Net/EnableInputFeedbackSounds  false
/Net/IconThemeName              Tango
/Net/SoundThemeName             default
/Net/ThemeName                  Xfce
/Xft/Antialias                  -1
/Xft/HintStyle                  hintnone
/Xft/Hinting                    -1
/Xft/RGBA                       none

*********************************************
Debian 10 XFCE - does NOT have the issue after changing theme to Adwaita
Thunar 1.8.4
Xfce 4.12

$ xfconf-query -c xsettings -lv
/Gtk/ButtonImages               true
/Gtk/CanChangeAccels            false
/Gtk/ColorPalette               black:white:gray50:red:purple:blue:light
blue:green:yellow:orange:lavender:brown:goldenrod4:dodger blue:pink:light
green:gray10:gray30:gray75:gray90
/Gtk/CursorThemeName           
/Gtk/CursorThemeSize            0
/Gtk/DecorationLayout           menu:minimize,maximize,close
/Gtk/FontName                   Sans 10
/Gtk/IconSizes                 
/Gtk/KeyThemeName               
/Gtk/MenuBarAccel               F10
/Gtk/MenuImages                 true
/Gtk/MonospaceFontName          Monospace 10
/Gtk/ToolbarIconSize            3
/Gtk/ToolbarStyle               icons
/Net/CursorBlink                true
/Net/CursorBlinkTime            1200
/Net/DndDragThreshold           8
/Net/DoubleClickDistance        5
/Net/DoubleClickTime            400
/Net/EnableEventSounds          false
/Net/EnableInputFeedbackSounds  false
/Net/IconThemeName              Tango
/Net/SoundThemeName             default
/Net/ThemeName                  Adwaita
/Xft/Antialias                  -1
/Xft/HintStyle                  hintnone
/Xft/Hinting                    -1
/Xft/RGBA                       none

*********************************************
CentOS 7
Thunar 1.6.16
Xfce 4.12

=============================================
jack_the_pirate 
2020-01-15 10:58:29

Also, please take a look at this screenshots:

[url=http://imgbox.com/TkqlmHnQ][img]https://thumbs2.imgbox.com/1c/ab/TkqlmHnQ_t.png[/img][/url] 
[url=http://imgbox.com/Q9AQXhkf][img]https://thumbs2.imgbox.com/1b/57/Q9AQXhkf_t.png[/img][/url] 
[url=http://imgbox.com/ICp1qsme][img]https://thumbs2.imgbox.com/02/49/ICp1qsme_t.png[/img][/url] 
[url=http://imgbox.com/KIbzFXjT][img]https://thumbs2.imgbox.com/12/ae/KIbzFXjT_t.png[/img][/url] 
[url=http://imgbox.com/UTVBDzz7][img]https://thumbs2.imgbox.com/af/01/UTVBDzz7_t.png[/img][/url] 
[url=http://imgbox.com/Y9T1UAjA][img]https://thumbs2.imgbox.com/c8/35/Y9T1UAjA_t.png[/img][/url] 
[url=http://imgbox.com/uYKlxO4U][img]https://thumbs2.imgbox.com/24/b4/uYKlxO4U_t.png[/img][/url] 
[url=http://imgbox.com/F2ovH5Kw][img]https://thumbs2.imgbox.com/86/95/F2ovH5Kw_t.png[/img][/url] 
[url=http://imgbox.com/3Sn2YX4R][img]https://thumbs2.imgbox.com/85/32/3Sn2YX4R_t.png[/img][/url] 
[url=http://imgbox.com/YRmrhzU0][img]https://thumbs2.imgbox.com/7e/08/YRmrhzU0_t.png[/img][/url] 
[url=http://imgbox.com/FqRijOUo][img]https://thumbs2.imgbox.com/fd/6c/FqRijOUo_t.png[/img][/url] 
[url=http://imgbox.com/YkOJVNNo][img]https://thumbs2.imgbox.com/7c/8f/YkOJVNNo_t.png[/img][/url] 
[url=http://imgbox.com/Ogq3BSHy][img]https://thumbs2.imgbox.com/b4/06/Ogq3BSHy_t.png[/img][/url] 
[url=http://imgbox.com/TR5rDs4Z][img]https://thumbs2.imgbox.com/45/79/TR5rDs4Z_t.png[/img][/url] 
[url=http://imgbox.com/YbZY4PPP][img]https://thumbs2.imgbox.com/b4/21/YbZY4PPP_t.png[/img][/url]

Last edited by jack_the_pirate (2020-01-15 10:58:57)

=============================================
jack_the_pirate 
2020-01-15 11:07:40

As you can see, in some screenshots, the Thunar right-click menu entry, which
is nearer the mouse cursor, appears automatically selected (incorrect) and in
other screenshots it doesn't (correct).

I think that the issue is solved in Thunar 1.8.4, which is the version that
comes in Debian 10.
However, that version is buggy because the custom actions don't work in the
Desktop folder (as you can see in the above screenshots) and that's why I have
also posted right-click menu screenshots of Debian 10 inside a folder (/etc).

However, I don't like this Thunar version because the right-click menu (context
menu) occupies too much vertical space.
I have created a topic about this a few months ago here:
https://forum.xfce.org/viewtopic.php?id=13239
Just compare these two screenshots and you can see that the Thunar custom
actions on Debian 10 doesn't show all, but Debian 9 yes:
http://imgbox.com/uYKlxO4U - Debian 9
http://imgbox.com/3Sn2YX4R - Debian 10

Also, it would be great if this could be solved because Debian 9 LTS will still
be active two and a half more years (06-2022) and CentOS 7 will also be active
until 2024.
I use these distros stable versions (Debian 9 instead of Debian 10, and CentOS
7 instead of CentOS 8) very much in some work situations, and I prefer them
because they are much more stable.
And having Thunar custom actions working right is a must because they save much
time.

Last edited by jack_the_pirate (2020-01-15 11:18:12)

=============================================
ToZ
2020-01-15 12:47:00

--------------
jack_the_pirate wrote:

"As you can see, in some screenshots, the Thunar right-click menu entry, which
is nearer the mouse cursor, appears automatically selected (incorrect) and in
other screenshots it doesn't (correct)."

--------------
ToZ

The Thunar 1.8.x series is built on GTK3 - which means it uses the GTK3
appearance settings. Themes like "Xfce" are a GTK2-only theme. If the issue is
solved by using a theme like Adwaita, then you will need to find and use a
GTK3-compatible theme.

--------------
jack_the_pirate wrote:

"I think that the issue is solved in Thunar 1.8.4, which is the version that
comes in Debian 10.
However, that version is buggy because the custom actions don't work in the
Desktop folder (as you can see in the above screenshots) and that's why I have
also posted right-click menu screenshots of Debian 10 inside a folder (/etc)."

--------------
ToZ

This was an unfortunate packaging error. Thunar 1.8.x use the version 3 thunarx
api and you need xfdesktop at least 4.13 development series. Since Debian won't
package development releases, this will be an unfortunate issue for this debian
version. You may wish to raise this as a bug in debian to see if they would be
willing to cherry-pick some xfdesktop 4.13 commits to make it work.

--------------
jack_the_pirate wrote:

"However, I don't like this Thunar version because the right-click menu
(context menu) occupies too much vertical space.
I have created a topic about this a few months ago here:
https://forum.xfce.org/viewtopic.php?id=13239
Just compare these two screenshots and you can see that the Thunar custom
actions on Debian 10 doesn't show all, but Debian 9 yes:
http://imgbox.com/uYKlxO4U - Debian 9
http://imgbox.com/3Sn2YX4R - Debian 10

Also, it would be great if this could be solved because Debian 9 LTS will still
be active two and a half more years (06-2022) and CentOS 7 will also be active
until 2024.
I use these distros stable versions (Debian 9 instead of Debian 10, and CentOS
7 instead of CentOS 8) very much in some work situations, and I prefer them
because they are much more stable.
And having Thunar custom actions working right is a must because they save much
time.

--------------
ToZ

With respect to the custom actions on the desktop, you will probably need to
follow-up with the debian devs to see if they can address the issue. Feel free
to also create a bug report against xfdesktop to see if they are willing to or
if it is even possible to backport the version 3 thunarx api to the xfdesktop
4.12 branch to address this issue

With respect to auto-clicking of a menu item, you may need to use a
GTK3-compatible theme like Adwaita (or Arc, or Greybird, or others).

=============================================
alcornoqui
2020-01-15 16:30:09

There's this Debian Stable bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930520

"Debian Bug report logs - #930520
xfdesktop4: regression : doesn't have the Thunar's custom actions
Package: xfdesktop4
Reported by: Johann <j.rios at laposte.net>
Date: Fri, 14 Jun 2019 11:33:02 UTC
Severity: normal
Found in version xfdesktop4/4.12.4-2"

=============================================
jack_the_pirate
2020-01-15 19:11:10

Above, where it reads (incorrect):
--------------
jack_the_pirate wrote:
Just compare these two screenshots and you can see that the Thunar custom
actions on Debian 10 doesn't show all, but Debian 9 yes:
http://imgbox.com/uYKlxO4U - Debian 9
http://imgbox.com/3Sn2YX4R - Debian 10
--------------

Read this instead (correct):
Just compare these two screenshots and you can see that the Thunar custom
actions on Debian 10 doesn't show all, but Debian 9 yes:
http://imgbox.com/UTVBDzz7 - Debian 9
http://imgbox.com/F2ovH5Kw - Debian 10

Last edited by jack_the_pirate (2020-01-15 19:11:33)

=============================================
kreemoweet
2020-01-16 08:36:47

I'm another afflicted with this Thunar bug. Ubuntu 18.04, xfdesktop4
4.12.3-ubuntu2, Thunar 1.6.15.
Theme is a slightly modified Greybird.
The menu item erroneously executed is usually, but not always, the one
immediately adjacent to the cursor position.
Quite frequently, but not always, right-clicking the same item again, after
dismissing or undoing the unwanted results
of the first right-click, will bring up a normal context menu with no items
selected (as should always be the case), or
with the adjacent item selected but not executed.

=============================================
ToZ
2020-01-16 09:53:05

Someone who is affected by this should create a bug report.

=============================================
CwF
2020-01-16 09:53:05

Maybe use an xinput test to show there are no extra clicks or any positional
drift while clicking in thunar.

=============================================

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Xfce-bugs mailing list