[Xfce-bugs] [Bug 16471] Order of partitions in tree view not stable

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Thu Feb 27 23:34:46 CET 2020


https://bugzilla.xfce.org/show_bug.cgi?id=16471

--- Comment #4 from alexxcons <alexxcons at xfce.org> ---
Just noticed that I cannot test, because I only have a single partition :F
(Saw that my USB devices are as well shown in different order, in bookmark/tree
view, though not sure if that belongs here)

remark on the patch:

This check can be removed:
if (item->device != NULL && device != NULL)
- The if in 1085 already protects from item->device != NULL
- "_thunar_return_if_fail (THUNAR_IS_DEVICE (device));" already protects from
"device == NULL"

a "git format-patch" would be nice.

Besides that, it looks good to me.

@Jay: Could you please give it a try ?

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Xfce-bugs mailing list