[Xfce-bugs] [Bug 16654] Replace deprecated GtkActionEntry with XfceGtkActionEntry

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16654

--- Comment #16 from alexxcons <alexxcons at xfce.org> ---
(In reply to Reuben Green from comment #15)
> (In reply to alexxcons from comment #14)
> 
> > - not setting "default-view" will just crash thunar 
>  I tried removing the "default-view" setting via xconf, but this does not
> cause a crash for me. What are your steps to make this crash?
I used xfce4-settings-editor to either put "empty string" or some random string
into "default-view" ... no problem, I can further debug that and provide a
fallback.

> So I think the intended behaviour here is as follows. The default view (set
> via the preferences dialog)
Uh, damn .. I overlooked that setting in the preferences dialog  :) ok, now
everything makes sense to me :P
Sorry for beeing a bit confused .... yes I totally agree that we should keep
that functionallity :)

Thank salot  for your patches, just pushed them to 'ReplaceGtkAction45' !

I as well pushed two more fixes to 'ReplaceGtkAction45'.
And I pushed a fix to the master branch of libxfce4ui (double registration of
accelerators, causing the crash above), which is now required when building
#45.

The following is now fixed:
- Crash when switching view and than pressing <Primary>A (select all)
- Keyboard navigation (arrow keys) on window menu do work now

Pending bugs:
- Shortcuts for UCAs do not work / are not shown (that used to work at some
previous iteration .. have to sort it out)
- Shortcuts without menu binding do not work (e.g. cycle tabs) .. have to be
added manuall. Consequence of recent changes in libxfce4ui
- crash if xfconf value "default-view" is empty

-- 
You are receiving this mail because:
You are the assignee for the bug.