[Xfce-bugs] [Bug 16686] Option to rename a file when existing copy conflicts

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16686

--- Comment #7 from alexxcons <alexxcons at xfce.org> ---
(In reply to Cyrille Pontvieux from comment #1)
> Created attachment 9717 [details]
> patch based on pause-copy branch

Patch does not apply on current master .. possibly you need to rebase on the
latest changes for the "pause" fix ?
(or is it me doing something wrong ?)

(In reply to Cyrille Pontvieux from comment #3)
> I'm still not sure on how to handle this for more than one file. I mean it could be cumbersome to have a dialog asking for a
> name whenever a conflict filename exists on the target directory. Maybe it's desirable, maybe not.
> If the more complicated (Dolphin-way) dialog is wanted, I could improve this patch, but I think some UI design mockups
> should be done first, just for everybody to be sure of what is wanted.
As far as I can see, as well dolphin asks per file .. so no problem on that.
Dolphin has some "compare pictures" feature .. yes, that's nice, though lets
start with your approach, which already should improve the current situation.

(In reply to Reuben Green from comment #4)
> For more than one file, perhaps you should open the bulk renamer?
That might be confusing for people which did not use the bulk renamer till now,
and it requires knowledge on the number of possible conflicts in advance. For
now I would keep it simple, and just open one dialog per conflict ... since it
is possible to press "cancel all", I guess we are fine.

(In reply to Reuben Green from comment #6)
> On second thoughts, maybe it's just the word "copy" that is bothering me here.
> Maybe in this patch one could just rename "file_a" to "file_a (1)", as that does not say it is a copy, just another version.
Afaik that's just the thunar default (or does the patch add extra-code to do
like that ?)  If you press ctrl+c + ctrl+v on a single file, you will get the
same result. So as a first step, re-using the default would be fine for me.
(Though we could generally change that default to use "file_a (1)" , etc. in a
different bug, if you think it would be worth it)
As you proposed, I guess using the rename dialog would fir better ..  would it
be hard to do ? We already have "thunar_dialogs_show_rename_file" which could
be used. If it would require alot of code-changes, I would go with the "copy
of" for this bug, and introduce "thunar_dialogs_show_rename_file" in a separate
bug.

(In reply to Reuben Green from comment #6)
> Also, there is now a new widget in libxfce4ui called XfceFilenameInput that is
> specifically for filename input and should make implementing a renamer
> dialog a bit easier. It is not used in thunar yet but I am planning to fix
So far I did not test the patch, though wouldnt it be fine to just use 
"thunar_dialogs_show_rename_file" here ? I guess only the internals of
"thunar_dialogs_show_rename_file" need to be changed in order to use
XfceFilenameInput.

-- 
You are receiving this mail because:
You are the assignee for the bug.