[Xfce-bugs] [Bug 16685] Allow to pause a job

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16685

--- Comment #9 from alexxcons <alexxcons at xfce.org> ---
(In reply to Cyrille Pontvieux from comment #8)
> Created attachment 9729 [details]
> New patch with whitespaces fixes and icons fixes

Works fine here, nice, thanks alot !

There is a typo for the pause icon:
media-playpack-pause --> media-playback-pause

Some minor changes I would suggest before pushing it:
- _thunar_return_if_fail / _thunar_return_val_if_fail guards in thunar-job.c
- _thunar_transfer_job_progress_check_pause --> why an extra method, instead of
just calling _thunar_transfer_job_check_pause inside
thunar_transfer_job_progress ?
- Why you added a underscore in front of the method name ? (In thunar afaik no
such convention is used)
- g_usleep (500 * 1000); Best put a comment: /* 500ms */

-- 
You are receiving this mail because:
You are the assignee for the bug.