[Xfce-bugs] [Bug 13680] Copying address bar text: unintuitive behaviour

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=13680

--- Comment #15 from alexxcons <alexxcons at xfce.org> ---
(In reply to DarkTrick from comment #14)
> Question here:
> The Shortcuts are apparently defined to work within the whole application. I
> would limit the shortcuts to work only as long as the respective view (view
> of the files) is selected. Are there any cons about this idea (spec?)?

IMO the second patch can be considered ok for patching 1.8.x branch (see
comment #11) .. and I think the concept is as well fine for master ( though I
would strongly prefer having a fix for the mentioned WIP branch to prevent
rebasing trouble) .. see reasoning below.

> Analysis result:
> GtkActionEntry defines the "<Control>C"-Command to trigger a function ...
Check my WIP branch ..  GtkActionEntry will be gone .. here the related bug, if
you want to track the process: Bug #16654

XfceGtkActionEntries for copy/paste/cut  are registered in thunar-launcher.c, 
xfce_gtk_accel_group_append is used in order to register the accel_pathes and
the related default accelerators:
https://git.xfce.org/xfce/libxfce4ui/tree/libxfce4ui/xfce-gtk-extensions.c#n415

Currently thunar-window registers all the accelerators of the launcher, using
window->accel_group (thunar_launcher_append_accelerators) .. that seems to be
required in order to display the accelerators on the window-menu.

Theorectially it might be possible to define a different accel_group for the
view and for the address bar, and register them for the same accelerator (Note
that this would result in two different entries in
"~/.config/Thunar/accels.scm")
Afaik splitting the window accel group for that reason would add alot of
complexity . I guess it would be beneficial to keep things simple and just do
like Theo suggested. Though feel free to prove me wrong ;)

If you like to implement Theo's patch for the WIP branch, that would be very
welcome !

-- 
You are receiving this mail because:
You are the assignee for the bug.