[Xfce-bugs] [Bug 15999] New: xscreensaver desktop file has same name as xfce4-screensaver

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15999

            Bug ID: 15999
           Summary: xscreensaver desktop file has same name as
                    xfce4-screensaver
    Classification: Xfce Core
           Product: Xfce4-session
           Version: 4.14.0
          Hardware: All
                OS: FreeBSD
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: xfce-bugs at xfce.org
          Reporter: madpilot at FreeBSD.org
  Target Milestone: Xfce 4.14

Hi,

In FreeBSD after updating xfce to 4.14 It has been noticed that xfce4-session
installs a .desktop startup file for xscreensaver, enabled by default.

At the same time xfce4-screensaver installs it's own .desktop file, also
enabled by default.

The two .desktop files happen to have the same exact content in the Name and
comment fields. This is problematic because in the Application Autostart
interface of the Session and Startup configuration tool the two entries appear
identical and cannot be distinguished.

Another issue is that if both are installed, being both enabled by default,
they end up conflicting. This can manifest it when the screen is locked as one
of the two screensavers showing it's unlock UI while the other grabs the
keyboard, preventing the user from properly unlocking the screen.

This has been reported in FreeBSD in these bug reports:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240804
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240810
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240811

In the FreeBSD ports we have a metaport (that is a port which installs nothing,
but depends on other ports to force their installation) for xfce which by
default also installs xfce4-screensaver. Due to this I have implemented two
workarounds:

- Install the xscreensaver.desktop file with the line Hidden=true which
disables it
- Change the Name field of xfce4-screensaver, so the lines can be distinguished
in the Application Autostart UI

I'm attaching a patch including the first change and also changes the .desktop
file name field. I have already filed a bug report for xfce4-screensaver with a
similar change.

I understand that switching to disabled by default could not be the best choice
for you. I also think a better name and description can be chosen.

I'm attaching the patch as an example of what can be done, and to start
discussion.

-- 
You are receiving this mail because:
You are the assignee for the bug.