[Xfce-bugs] [Bug 15970] New: Gtk-CRITICAL and permanently unavailable user-customizable-action shortcuts

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15970

            Bug ID: 15970
           Summary: Gtk-CRITICAL and permanently unavailable
                    user-customizable-action shortcuts
    Classification: Xfce Core
           Product: Thunar
           Version: 1.8.9
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: UCA
          Assignee: xfce-bugs at xfce.org
          Reporter: reubengreen73 at gmail.com
  Target Milestone: 1.8.10

Created attachment 9033
  --> https://bugzilla.xfce.org/attachment.cgi?id=9033&action=edit
Patch to fix these bugs

While looking at thunar bug #15119, I uncovered two new bugs in the user
customizable action (uca) plugin, affecting both the master and xfce-4.14
branches. I have included both bugs in this one report, together with a patch
to fix them.

The first bug can be reproduced as follows. Run thunar from a terminal and
create a new uca (it does not matter what parameters you enter, you can just
put 'blah' in the text boxes and not enter a shortcut or any other details).
When you click OK, the terminal will show a Gtk-CRITICAL error. For me, the
error is

(thunar:17196): Gtk-CRITICAL **: 15:59:40.857: gtk_accel_map_lookup_entry:
assertion '_gtk_accel_path_is_valid (accel_path)' failed

This is caused by a missing check for a NULL value (the NULL value itself is
not a bug, as it represents the absence of a previous shortcut), and the first
commit in the attached patch fixes this bug.

The second bug can be reproduced as follows. Create a new uca (again, the
parameters entered do not matter) and assign it a keyboard shortcut. Then
delete this uca from the list in the dialog, and try to create another uca with
the same shortcut. You will get a dialog telling you that this shortcut is in
use. This problem then persists even if you exit thunar between creating and
deleting the initial uca, and attempting to create the second uca. The shortcut
thus becomes permanently unusable, and one has to manually edit the accels.scm
config file to fix this. The second commit in the attached patch fixes this
bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.