[Xfce-bugs] [Bug 15917] Thunar SendTo Email: improve archives detection

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15917

--- Comment #7 from alexxcons <alexxcons at xfce.org> ---
> Great, I'll leave a link here when I do this.
Thanks !

> That's a good question. I also wanted to do like this but it turned out that the sendto-email plugin is not a shared library but a separate 
> command line tool /usr/local/lib/Thunar/thunar-sendto-email so it doesn't use the thunarx API at all.
Meh, that's a pity .. ok, I'll apply the fix later on.

> If the hack is small, simple, well documented, localized into a function which internal implementation can be easily changed latter,
> backward compatible and in the same time more flexible then I'm pretty sure it's ok to use it.
And still it is a hack. I dont think much is gained by replacing one hack by
another.

> BTW consider this: the listing of all archive MIME types is also a hack, and very dirty: we already have a problem when user sees an archive icon on the file but can't extract it from the menu. Yes, potentially there can be a situation when the archive type is not supported by the archive manager e.g. XArchiver doesn't support Brotli yet, but this will be eventually fixed.
As you said yourself. Using the other hack may bring other pitfalls .. e.g.
attempt to load unsupported archive formats. As well the icon name might change
in the future. How about a different icon for uncompressed archives ?

-- 
You are receiving this mail because:
You are the assignee for the bug.