[Xfce-bugs] [Bug 15917] Thunar SendTo Email: improve archives detection

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15917

--- Comment #5 from Sergey Ponomarev <stokito at gmail.com> ---
> Just open a bug should be fine.

Great, I'll leave a link here when I do this.

> why we need to have a separate "isArchive" check here, when we can re-use your thunarx API ?

That's a good question. I also wanted to do like this but it turned out that
the sendto-email plugin is not a shared library but a separate command line
tool /usr/local/lib/Thunar/thunar-sendto-email so it doesn't use the thunarx
API at all.

> We can fix it in a different way now

If the hack is small, simple, well documented, localized into a function which
internal implementation can be easily changed latter, backward compatible and
in the same time more flexible then I'm pretty sure it's ok to use it.

-- 
You are receiving this mail because:
You are the assignee for the bug.