[Xfce-bugs] [Bug 15873] Unification of "close multi tab" dialog

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15873

--- Comment #15 from Igor <f2404 at yandex.ru> ---
(In reply to alexxcons from comment #14)
> Nice !  Just one minor thing: (sorry, I missed that on the first patch )
> 
> > +#if GTK_CHECK_VERSION (3, 0, 0)
> Afaik no ifdef is needed. Should be ok to assume that gtk 3.18.0 is used
> (Minimal requirement defined in configure.ac.in)
Are we still building libxfce4ui for both gtk2 and gtk3? If so, the #if is
needed.

Reuben, have you checked that your change builds fine with gtk2?

> Igor, possibly you have push access to xfce4ui ?  (If not, we will have to
> ask on #xfce-dev )
No, I don't think I have push access to the repo.

-- 
You are receiving this mail because:
You are the assignee for the bug.