[Xfce-bugs] [Bug 15873] Unification of "close multi tab" dialog

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15873

--- Comment #7 from Reuben Green <reubengreen73 at gmail.com> ---
Igor, I've just had another look at the code, and in fact the function in its
current form does not return immediately if parent is NULL. The check
g_return_val_if_fail (parent == NULL || GTK_IS_WINDOW (parent), 0);
returns 0 if parent fails to be either NULL or a valid GtkWindow, so NULL is
allowed. Indeed, NULL indicates the lack of a parent window, and this is used
in the demonstrator program. Sorry, I wasn't concentrating when I replied
before!

So I suppose the question is, should the dialog be allowed to have no parent
window? Since the dialog is about tabs in a main window, it probably won't
normally be used without a parent, but maybe it's a good idea to give people
the choice in case they want to organise things differently in their program?
I'm not sure, what you think?

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.