[Xfce-bugs] [Bug 16138] Thunar 1.8.10 crashing on startup in FreeBSD (pango 1.42.4 - glib 2.56.3)

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16138

alexxcons <alexxcons at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexxcons at xfce.org
           Assignee|xfce-bugs at xfce.org          |alexxcons at xfce.org
             Status|NEW                         |ASSIGNED

--- Comment #5 from alexxcons <alexxcons at xfce.org> ---
Created attachment 9209
  --> https://bugzilla.xfce.org/attachment.cgi?id=9209&action=edit
patch

Sorry for the trouble, and thanks alot for the patches !

I plan to apply a mix of your patches. IMO we should have the pango dependency
listed in configure.ac.in, like proposed in the patch of bug #16136
In addition I think it is a good idea to #IFDEF not only the concrete call, but
as well #IFDEF the set of the gobject property in order to show that the
property is set conditionally, like proposed in attachment 9206 

I still dont understand why PANGO_VERSION_1_44 seems to be defined for you /
the related code in the current ifdef is executed ... but whatever :)

After you tested my patch, I would push it and release thunar 1.8.11, to
prevent possible further breakage for other packagers.

-- 
You are receiving this mail because:
You are the assignee for the bug.