[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16041

--- Comment #9 from Adam Purkrt <adam at purkrt.net> ---
After some more research, I now think my patch (attachment 9137) is not the
right way how to remedy this. The cause of the gap is simply padding - it is
set to 3 pixels in thunar/thunar-icon-view.c

  g_object_set (G_OBJECT (THUNAR_STANDARD_VIEW (icon_view)->icon_renderer),
                "ypad", 3u,
                NULL);

https://git.xfce.org/xfce/thunar/tree/thunar/thunar-icon-view.c#n101

Change the "3u" to "0u", recompile thunar and voila - the gap is gone. This
time, though, also visually. But I would be all for this change - I do not miss
the three pixels, they do not scale with zoom level anyway and it would make
the code less readable to make them clickable (imo).

If you are wondering why 3u leads to only 2 pixel unclickable gap (and it is
really two pixels, not three), the reason lies in the function
exo_icon_view_get_item_at_coords in exo/exo-icon-view.c. The inequalities there
should be "<" instead of "<=". The extra "=" brings the extra pixel (I verified
this experimentally).

https://git.xfce.org/xfce/exo/tree/exo/exo-icon-view.c#n4359
and also lines 4360, 4373, 4374

-- 
You are receiving this mail because:
You are the assignee for the bug.