[Xfce-bugs] [Bug 15433] Make xfce4-screenshooter and the screenshot plugin use same dialogs

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15433

Andre Miranda <andreldm at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreldm at xfce.org

--- Comment #1 from Andre Miranda <andreldm at xfce.org> ---
(In reply to scootergrisen from comment #0)
> Its very confusing to me the way dialogs works in xfce4-screenshooter and
> the screenshot plugin.
> 
> if i run xfce4-screenshooter i see a dialog.
> If i go to screenshot plugin preferences i see almost the same identical
> dialog. But that is for preferences only.
> 
> So two dialogs that looks almost identical. One can be used to take
> screenshots but the other can only be used to change preferences.
It's just code reuse.

> I suggest making xfce4-screenshooter and the screenshot plugin work the same.
> That is if i start xfce4-screenshooter and click the screenshot plugin icon
> i would think its better to show the same dialog.
I don't think this makes sense, in one scenario the dialog is meant to ask how
to take a screenshot and in another context it meant to tell the plugin how to
take screenshots when it is activated.

> How about showing the dialog with the preview in both cases and then add a
> button for preferences. Or maybe have two tabs. One for preferences and one
> for taking the screenshot.
This would only complicate the scenario where screenshooter is invoked via
keyboard keys (I guess the most used), because there is no need to access/set
preferences, it just remembers the last selected options.

> I dont see any product/component for screenshot plugin on
> https://bugzilla.xfce.org/enter_bug.cgi?classification=Panel%20Plugins so is
> it missing or have it maybe been removed in next release or something?
Screenshooter is a very simple tool with few bugs, just select General, no need
to bureaucratize bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.