[Xfce-bugs] review requested: [Bug 11317] xfce4-keyboard-settings garbles keyboard list in non-UTF locale : [Attachment 8470] Reduce string copy/freeing...

[bugzilla-daemon at xfce.org]

Mikhail T. <mi+xfce-2014 at aldan.algebra.com> has asked Igor Slepchin
<igor.slepchin at gmail.com> for review:
Bug 11317: xfce4-keyboard-settings garbles keyboard list in non-UTF locale
https://bugzilla.xfce.org/show_bug.cgi?id=11317

Attachment 8470: Reduce string copy/freeing...
https://bugzilla.xfce.org/attachment.cgi?id=8470&action=edit



--- Comment #2 from Mikhail T. <mi+xfce-2014 at aldan.algebra.com> ---
Created attachment 8470
  --> https://bugzilla.xfce.org/attachment.cgi?id=8470&action=edit
Reduce string copy/freeing...

With the strings being used verbatim now, do we even need to dup/free destroy
them?

How about this patch?..