[Xfce-bugs] [Bug 15184] Crash on mount/unmount on FreeBSD 11.2, 12.0, starting from 1.6.16
bugzilla-daemon at xfce.org
bugzilla-daemon at xfce.org
Mon Mar 11 02:17:26 CET 2019
https://bugzilla.xfce.org/show_bug.cgi?id=15184
--- Comment #2 from Ivan 83 <rozhuk.im at gmail.com> ---
Looks like there is few different bugs.
All 4 commits reverted, on thunar close:
====================================================================================
(thunar:81543): GLib-GObject-WARNING **: 03:30:01.535: invalid uninstantiatable
type '(null)' in cast to 'GObject'
(thunar:81543): GLib-GObject-CRITICAL **: 03:30:01.535: g_object_unref:
assertion 'G_IS_OBJECT (object)' failed
====================================================================================
With:
https://git.xfce.org/xfce/thunar/commit/?h=xfce-4.12&id=95925eb023144ebe199234b65bafc1f08696f5de
1. thunar /media/da4
2. mount_msdosfs -o noatime -o longnames -m 644 -M 755 -D CP866 -L ru_RU.UTF-8
/dev/da4 /media/da4
3. refresh
====================================================================================
(thunar:22247): thunar-CRITICAL **: 03:38:33.429: thunar_tree_model_get_value:
assertion 'iter->user_data != ((void *)0)' failed
(thunar:22247): GLib-GObject-CRITICAL **: 03:38:33.429: g_value_transform:
assertion 'G_IS_VALUE (src_value)' failed
(thunar:22247): GLib-GObject-WARNING **: 03:38:33.429: unable to set property
'device' of type 'ThunarDevice' from value of type '(null)'
(thunar:22247): thunar-CRITICAL **: 03:38:33.429: thunar_tree_model_get_value:
assertion 'iter->user_data != ((void *)0)' failed
(thunar:22247): GLib-GObject-CRITICAL **: 03:38:33.429: g_value_transform:
assertion 'G_IS_VALUE (src_value)' failed
(thunar:22247): GLib-GObject-WARNING **: 03:38:33.429: unable to set property
'file' of type 'ThunarFile' from value of type '(null)'
(thunar:22247): thunar-CRITICAL **: 03:38:33.429: thunar_tree_model_get_value:
assertion 'iter->user_data != ((void *)0)' failed
(thunar:22247): GLib-GObject-CRITICAL **: 03:38:33.429: g_value_transform:
assertion 'G_IS_VALUE (src_value)' failed
(thunar:22247): GLib-GObject-WARNING **: 03:38:33.429: unable to set property
'text' of type 'gchararray' from value of type '(null)'
(thunar:22247): thunar-CRITICAL **: 03:38:33.429: thunar_tree_model_get_value:
assertion 'iter->user_data != ((void *)0)' failed
(thunar:22247): GLib-GObject-CRITICAL **: 03:38:33.429: g_value_transform:
assertion 'G_IS_VALUE (src_value)' failed
(thunar:22247): GLib-GObject-WARNING **: 03:38:33.429: unable to set property
'attributes' of type 'PangoAttrList' from value of type '(null)'
(thunar:22247): thunar-CRITICAL **: 03:39:15.287: thunar_tree_model_get_value:
assertion 'iter->user_data != ((void *)0)' failed
(thunar:22247): GLib-GObject-CRITICAL **: 03:39:15.287: g_value_transform:
assertion 'G_IS_VALUE (src_value)' failed
(thunar:22247): GLib-GObject-WARNING **: 03:39:15.287: unable to set property
'device' of type 'ThunarDevice' from value of type '(null)'
(thunar:22247): thunar-CRITICAL **: 03:39:15.287: thunar_tree_model_get_value:
assertion 'iter->user_data != ((void *)0)' failed
(thunar:22247): GLib-GObject-CRITICAL **: 03:39:15.287: g_value_transform:
assertion 'G_IS_VALUE (src_value)' failed
(thunar:22247): GLib-GObject-WARNING **: 03:39:15.287: unable to set property
'file' of type 'ThunarFile' from value of type '(null)'
(thunar:22247): thunar-CRITICAL **: 03:39:15.287: thunar_tree_model_get_value:
assertion 'iter->user_data != ((void *)0)' failed
(thunar:22247): GLib-GObject-CRITICAL **: 03:39:15.287: g_value_transform:
assertion 'G_IS_VALUE (src_value)' failed
(thunar:22247): GLib-GObject-WARNING **: 03:39:15.287: unable to set property
'text' of type 'gchararray' from value of type '(null)'
(thunar:22247): thunar-CRITICAL **: 03:39:15.287: thunar_tree_model_get_value:
assertion 'iter->user_data != ((void *)0)' failed
(thunar:22247): GLib-GObject-CRITICAL **: 03:39:15.287: g_value_transform:
assertion 'G_IS_VALUE (src_value)' failed
(thunar:22247): GLib-GObject-WARNING **: 03:39:15.287: unable to set property
'attributes' of type 'PangoAttrList' from value of type '(null)'
(thunar:22247): Gtk-CRITICAL **: 03:39:15.290: gtktreeview.c:5016
(gtk_tree_view_bin_expose): assertion `has_next' failed.
There is a disparity between the internal view of the GtkTreeView,
and the GtkTreeModel. This generally means that the model has changed
without letting the view know. Any display from now on is likely to
be incorrect.
(thunar:22247): Gtk-CRITICAL **: 03:39:33.355: gtk_tree_view_unref_tree_helper:
assertion 'node != NULL' failed
(thunar:22247): GLib-GObject-WARNING **: 03:39:33.372: invalid uninstantiatable
type '(null)' in cast to 'GObject'
(thunar:22247): GLib-GObject-CRITICAL **: 03:39:33.372: g_object_unref:
assertion 'G_IS_OBJECT (object)' failed
====================================================================================
With:
https://git.xfce.org/xfce/thunar/commit/?h=xfce-4.12&id=81fc76226596a82b50c08fa2a2ab50f619ffa1a3
OK, no warnings/errors on plug/unplug/refresh
With
https://git.xfce.org/xfce/thunar/commit/?h=xfce-4.12&id=2963db9bfa7a9305a3f49037e1ed0caa1082e418
on start, if:
1. mount_msdosfs -o noatime -o longnames -m 644 -M 755 -D CP866 -L ru_RU.UTF-8
/dev/da4 /media/da4
2. thunar /media/da4
====================================================================================
(thunar:9670): Gdk-WARNING **: 03:55:47.774: gdk_window_set_icon_list: icons
too large
(thunar:9670): thunar-CRITICAL **: 03:55:47.818: thunar_file_get_info:
assertion '(((__extension__ ({ GTypeInstance *__inst = (GTypeInstance*)
((file)); GType __t = ((thunar_file_get_type ())); gboolean __r; if (!__inst)
__r = (0); else if (__inst->g_class && __inst->g_class->g_type == __t) __r =
(!(0)); else __r = g_type_check_instance_is_a (__inst, __t); __r; }))))' failed
(thunar:9670): GLib-GIO-CRITICAL **: 03:55:47.818:
g_file_info_get_attribute_boolean: assertion 'G_IS_FILE_INFO (info)' failed
====================================================================================
With
https://git.xfce.org/xfce/thunar/commit/?h=xfce-4.12&id=2963db9bfa7a9305a3f49037e1ed0caa1082e418
https://git.xfce.org/xfce/thunar/commit/?h=xfce-4.12&id=87731222ada23b24cfbb2c422d3ef2907c8fead3
OK.
Looks like problems with:
https://git.xfce.org/xfce/thunar/commit/?h=xfce-4.12&id=95925eb023144ebe199234b65bafc1f08696f5de
I build with reverted this commit and all works fine.
I will do more test at this week at work, but I think that is it.
PS: compilation time warnings:
====================================================================================
thunar-tree-view.c:765:15: warning: variable 'file' is used uninitialized
whenever 'if' condition is false [-Wsometimes-uninitialized]
if (path != NULL && gtk_tree_model_get_iter (GTK_TREE_MODEL
(view->model), &iter, path))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
thunar-tree-view.c:782:15: note: uninitialized use occurs here
if (file)
^~~~
thunar-tree-view.c:765:11: note: remove the 'if' if its condition is always
true
if (path != NULL && gtk_tree_model_get_iter (GTK_TREE_MODEL
(view->model), &iter, path))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
thunar-tree-view.c:765:15: warning: variable 'file' is used uninitialized
whenever '&&' condition is false [-Wsometimes-uninitialized]
if (path != NULL && gtk_tree_model_get_iter (GTK_TREE_MODEL
(view->model), &iter, path))
^~~~~~~~~~~~
thunar-tree-view.c:782:15: note: uninitialized use occurs here
if (file)
^~~~
thunar-tree-view.c:765:15: note: remove the '&&' if its condition is always
true
if (path != NULL && gtk_tree_model_get_iter (GTK_TREE_MODEL
(view->model), &iter, path))
^~~~~~~~~~~~~~~
thunar-tree-view.c:705:26: note: initialize the variable 'file' to silence this
warning
ThunarFile *file;
^
= NULL
thunar-tree-view.c:765:15: warning: variable 'device' is used uninitialized
whenever 'if' condition is false [-Wsometimes-uninitialized]
if (path != NULL && gtk_tree_model_get_iter (GTK_TREE_MODEL
(view->model), &iter, path))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
thunar-tree-view.c:770:16: note: uninitialized use occurs here
if ((device != NULL && thunar_device_is_mounted (device)) ||
^~~~~~
thunar-tree-view.c:765:11: note: remove the 'if' if its condition is always
true
if (path != NULL && gtk_tree_model_get_iter (GTK_TREE_MODEL
(view->model), &iter, path))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
thunar-tree-view.c:765:15: warning: variable 'device' is used uninitialized
whenever '&&' condition is false [-Wsometimes-uninitialized]
if (path != NULL && gtk_tree_model_get_iter (GTK_TREE_MODEL
(view->model), &iter, path))
^~~~~~~~~~~~
thunar-tree-view.c:770:16: note: uninitialized use occurs here
if ((device != NULL && thunar_device_is_mounted (device)) ||
^~~~~~
thunar-tree-view.c:765:15: note: remove the '&&' if its condition is always
true
if (path != NULL && gtk_tree_model_get_iter (GTK_TREE_MODEL
(view->model), &iter, path))
^~~~~~~~~~~~~~~
thunar-tree-view.c:704:28: note: initialize the variable 'device' to silence
this warning
ThunarDevice *device;
^
= NULL
====================================================================================
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the Xfce-bugs
mailing list