[Xfce-bugs] [Bug 15616] New: xfconf tests: xfconf_tests_start() is not checking Ping reply correctly

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15616

            Bug ID: 15616
           Summary: xfconf tests: xfconf_tests_start() is not checking
                    Ping reply correctly
    Classification: Xfce Core
           Product: Xfconf
           Version: GIT Master
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: xfce-bugs at xfce.org
          Reporter: mgorny at gentoo.org
  Target Milestone: Xfce 4.12

The xfconf_tests_start() function is issuing Ping method call in order to
determine whether xfconfd has started. However, it wrongly assumes that the
method call with fail if xfconfd is not running. In reality, D-Bus will issue
an 'error' response. The test code should check for that response in order to
correctly report missing xfconfd.

If I add g_dbus_message_print() to the code, I see that ret contains the
following:

    Type:    error
    Flags:   no-reply-expected
    Version: 0
    Serial:  3
    Headers:
      error-name -> 'org.freedesktop.DBus.Error.ServiceUnknown'
      reply-serial -> uint32 2
      destination -> ':1.41'
      sender -> 'org.freedesktop.DBus'
      signature -> signature 's'
    Body: ('The name org.xfce.Xfconf was not provided by any .service files',)
    UNIX File Descriptors:
      (none)

For comparison, if xfconfd is started correctly, it contains:

    Type:    method-return
    Flags:   no-reply-expected
    Version: 0
    Serial:  301
    Headers:
      reply-serial -> uint32 2
      destination -> ':1.128'
      sender -> ':1.5'
    Body: ()
    UNIX File Descriptors:
      (none)

I'll attach a patch in a few minutes.

-- 
You are receiving this mail because:
You are the assignee for the bug.