[Xfce-bugs] [Bug 15533] Thunar writes mimeapps.list over every time a file is opened.

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15533

alexxcons <alexxcons at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexxcons at xfce.org

--- Comment #3 from alexxcons <alexxcons at xfce.org> ---
Thanks for reporting & for the patch (though Theo, you meanwhile should know
that "git format-patch" is the way to go  :P )

Some improvements are needed:

> * thunar_file_get_default_handler:
> * @file : a #ThunarFile instance.
> *
> * Returns the default #GAppInfo for @file or %NULL if there is none.

So a NULL check is required to prevent seg faults.

> GList *
>g_app_info_get_recommended_for_type (const gchar *content_type);
> ....
> Returns
>
> GList of GAppInfos for given content_type or NULL on error. 

Same here.

Could you please add these checks ?

As well it would be nice to have a comment, telling that the first entry of
"g_app_info_get_recommended_for_type()" is the last used application.

-- 
You are receiving this mail because:
You are the assignee for the bug.