[Xfce-bugs] [Bug 15553] New: xfce-desktop.c:1198:13: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Wed Jun 5 09:20:04 CEST 2019


https://bugzilla.xfce.org/show_bug.cgi?id=15553

            Bug ID: 15553
           Summary: xfce-desktop.c:1198:13: warning: this ‘if’ clause does
                    not guard... [-Wmisleading-indentation]
    Classification: Xfce Core
           Product: Xfdesktop
           Version: Unspecified
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: xfce-bugs at xfce.org
          Reporter: dcb314 at hotmail.com
  Target Milestone: Xfce 4.14

Source code is

            /* no icons on the desktop, grab the focus and pop up the menu */
            if(!gtk_widget_has_grab(w))
                gtk_grab_add(w);

                xfce_desktop_popup_root_menu(desktop, button, evt->time);
                return TRUE;

maybe better code

            /* no icons on the desktop, grab the focus and pop up the menu */
            if(!gtk_widget_has_grab(w)) {
                gtk_grab_add(w);

                xfce_desktop_popup_root_menu(desktop, button, evt->time);
                return TRUE;
            }

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Xfce-bugs mailing list