[Xfce-bugs] [Bug 15635] Gtk-CRITICAL when closing main window

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15635

alexxcons <alexxcons at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexxcons at xfce.org
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from alexxcons <alexxcons at xfce.org> ---
(In reply to Reuben Green from comment #1)
> Created attachment 8813 [details]
> Patch to fix bug 15635
> 
Welcome!
Your patch looks good to me and seems to fix the bug.
Formatting, commit message, etc, all is fine (iirc first time everything seems
to be ok on a "first patch" :P ) 

Pushed it to master and 4.14 branch.

I as well would assume to receive at least some dedicated Warning / Error when
a widget reveives a signal in while in a bad state.
( Though I dont know much about gtk internals)

Best open a bug for it on https://gitlab.gnome.org/GNOME/gtk and see what the
devs tell (or first search if such a bug already exists)

Thanks for your contribution !

-- 
You are receiving this mail because:
You are the assignee for the bug.