[Xfce-bugs] [Bug 15635] Gtk-CRITICAL when closing main window

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15635

Reuben Green <reubengreen73 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reubengreen73 at gmail.com

--- Comment #1 from Reuben Green <reubengreen73 at gmail.com> ---
Created attachment 8813
  --> https://bugzilla.xfce.org/attachment.cgi?id=8813&action=edit
Patch to fix bug 15635

Small patch to fix this (it just swaps the order of two lines of code).

After some experimenting, I found that thunar_clipboard_manager_dispose was
being called during the unrealize-ing of the window. When the clipboard is
non-empty, this results in a call to gtk_clipboard_store. This call runs a glib
event loop, which then processes signals that are ultimately passed to the
window's GtkPaned member, which is in a bad state due to being part-way through
unrealize-ation, and  this causes the error. The patch fixes this by waiting
until after the GtkWidget class has unrealize the window before calling
g_object_unref on the clipboard manager.

So I suppose this is really a gtk bug, since gtk is allowing widgets to receive
signals while in a bad state?

Also this is my first go at submitting a patch, so if I have done something
wrong/badly (either in the patch itself or the submission process), please let
me know!

-- 
You are receiving this mail because:
You are the assignee for the bug.