[Xfce-bugs] [Bug 15654] [PATCH] Toggle the show desktop button when drag a file over there

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Thu Jul 4 01:49:34 CEST 2019


https://bugzilla.xfce.org/show_bug.cgi?id=15654

--- Comment #3 from Matias De lellis <mati86dl at gmail.com> ---
Hi Simon,

> When testing it a bit I noticed that the 1sec may be a bit ample, but alright.

It gave me the same impression, but it is difficult to establish an adequate
value.. Now I did it with 500 ms, in line with the tasklist plugin that have a
similar behavior. This seems fast, but at least it's consistent.. 

> 1) But what I really miss is visual feedback of the hover. I think that would help make this a little more intuitive.

Done.. However there is some conflict with the CSS of greybird, testing it with
adwaita works.

> 2) The button is easily activated again and the state reverted if one hovers too long over the button. I guess that's an issue with the general design of the plugin (that it's a toggle) and not so easily fixable.

In general I do not like saying this, but it's a feature. haha.
GTK emits drag_motion again when you move the mouse over the widget even if you
have not come out on it.

> If you could tackle 1) that'd be awesome, I'm happy to merge it in before 4.14 because I feel the plugin should have always been doing this ;)

Greats,
By the way, congratulations for all the work you are doing in this release. ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Xfce-bugs mailing list