[Xfce-bugs] review granted: [Bug 15039] Drop include on deprecated sys/sysctl.h : [Attachment 8261] headers.diff

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Thu Jan 24 08:09:43 CET 2019


Landry Breuil <landry at xfce.org> has granted  review:
Bug 15039: Drop include on deprecated sys/sysctl.h
https://bugzilla.xfce.org/show_bug.cgi?id=15039

Attachment 8261: headers.diff
https://bugzilla.xfce.org/attachment.cgi?id=8261&action=edit



--- Comment #6 from Landry Breuil <landry at xfce.org> ---
Comment on attachment 8261
  --> https://bugzilla.xfce.org/attachment.cgi?id=8261
headers.diff

Much better with the patch as master now builds fine on OpenBSd with it, but i
dont really like #include scattered around .c files - wouldnt it be better to
add a #ifdef block with them at the top ?


More information about the Xfce-bugs mailing list