[Xfce-bugs] review requested: [Bug 14928] Gigolo WebDav and FTP asks for share name : [Attachment 8315] potential fix v1

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Fri Feb 22 15:48:35 CET 2019


Landry Breuil <landry at xfce.org> has asked Sean Davis <bluesabre at xfce.org> for
review:
Bug 14928: Gigolo WebDav and FTP asks for share name
https://bugzilla.xfce.org/show_bug.cgi?id=14928

Attachment 8315: potential fix v1
https://bugzilla.xfce.org/attachment.cgi?id=8315&action=edit



--- Comment #6 from Landry Breuil <landry at xfce.org> ---
Created attachment 8315
  --> https://bugzilla.xfce.org/attachment.cgi?id=8315&action=edit
potential fix v1

Here's a potential fix on top of master, which this i'm able to create ssh &
ftp mounts - havent tested smb yet.

I'm not 100% happy with it, since the logic changed in the commit might have to
be improved instead of adding kludges like this. The 'port' value from the
method isnt used either, the port field always default to 0 while to my
understanding it should change when switching methods.


More information about the Xfce-bugs mailing list