[Xfce-bugs] [Bug 15727] Replacing a file via Cut and Paste in the same filesystem makes a copy

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15727

--- Comment #4 from Reuben Green <reubengreen73 at gmail.com> ---
Created attachment 8881
  --> https://bugzilla.xfce.org/attachment.cgi?id=8881&action=edit
patch to allow native file move in overwrite with user confirmation

I see now that my previous comment here was wrong: as alexxcons said, the
fallback behaviour is coming from thunar itself, not g_file_move. My bad!

Here is a patch implementing alexxcons's suggestion, by retrying with
G_FILE_COPY_OVERWRITE after user confirmation via thunar_job_ask_replace.
However, at least on my system there is no retry option in this dialog, so I
have not put the new code in a loop. The patch also fixes some  (possible)
small memory leaks in the same function.

Criticisms and suggestions for improvement are most welcome!

-- 
You are receiving this mail because:
You are the assignee for the bug.