[Xfce-bugs] [Bug 15789] New: Hangs when Places/Bookmark target is autofs and doesn't exist/not available

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15789

            Bug ID: 15789
           Summary: Hangs when Places/Bookmark target is autofs and
                    doesn't exist/not available
    Classification: Xfce Core
           Product: Thunar
           Version: 1.8.6
          Hardware: PC (x86_64)
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: Core
          Assignee: xfce-bugs at xfce.org
          Reporter: 0.xubuntu at iam.tj
  Target Milestone: 1.6.16

Experiencing this on Xubuntu 18.04, This affects Thunar 1.6.15 and is also
reproduced in Xubuntu 19.10 daily LiveISO with Thunar 1.8.6-0ubuntu1.

Seems to be related to #12467 and #12265.

I get this for 2 scenarios:

1. Having previously added GTK3 bookmarks (Places) that point to autofs
mount-points I start Thunar when the mount target is not available / does not
exist
2. An autofs network CIFS share previously added as GTK3 bookmark (Places) that
isn't reachable

Can be reproduced using a couple of systemd unit files that (for testing) point
to a non-existent device target.

The problem is Thunar, or the underlying gvfs backend, are repeatedly retrying
every 5 to 10 seconds or so and Thunar isn't responsive to the operator.

Steps:

$ sudo mkdir /mnt/test


# Now start Thunar and create a bookmark (Place) by dragging /mnt/test/ to the
Places area.
# Close/quit Thunar
# Create unit files that will use autofs - note that /dev/sdz2 is almost
guaranteed not to exist which is what we need

$ systemctl cat mnt-test.{,auto}mount
# /run/systemd/system/mnt-test.mount
[Unit]
Description=Test Mount

[Mount]
What=/dev/sdz2
Where=/mnt/test
DirectoryMode=0750

# /run/systemd/system/mnt-test.automount
[Unit]
Before=local-fs.target
Before=mnt-test.mount

[Automount]
Where=/mnt/test
DirectoryMode=0750
TimeoutIdleSec=60

$ sudo mkdir /run/systemd/system/local-fs.target.wants
$ sudo ln -s ../mnt-test.automount /run/systemd/system/local-fs.target.wants/

$ sudo systemctl daemon-reload
$ sudo systemctl restart local-fs.target

Start Thunar and try to use it. With 1.8.6 it hangs even before drawing its
window resulting in the window showing the desktop background. Watching the
logs it shows a thread belonging to Thunar repeatedly triggering a mount
attempt on the non-existent device. I used strace to see that it is trying to
open() the directory.

$ journalctl -f 

Aug 06 16:23:09 xubuntu systemd[1]: mnt-test.automount: Got automount request
for /mnt/test, triggered by 3644 (gmain)
Aug 06 16:24:39 xubuntu systemd[1]: dev-sdz2.device: Job dev-sdz2.device/start
timed out.
Aug 06 16:24:39 xubuntu systemd[1]: Timed out waiting for device /dev/sdz2.
Aug 06 16:24:39 xubuntu systemd[1]: Dependency failed for Test Mount.
Aug 06 16:24:39 xubuntu systemd[1]: mnt-test.mount: Job mnt-test.mount/start
failed with result 'dependency'.
Aug 06 16:24:39 xubuntu systemd[1]: dev-sdz2.device: Job dev-sdz2.device/start
failed with result 'timeout'.
Aug 06 16:24:39 xubuntu systemd[1]: mnt-test.automount: Got automount request
for /mnt/test, triggered by 3644 (gmain)
Aug 06 16:26:09 xubuntu systemd[1]: dev-sdz2.device: Job dev-sdz2.device/start
timed out.
Aug 06 16:26:09 xubuntu systemd[1]: Timed out waiting for device /dev/sdz2.
Aug 06 16:26:09 xubuntu systemd[1]: Dependency failed for Test Mount.
Aug 06 16:26:09 xubuntu systemd[1]: mnt-test.mount: Job mnt-test.mount/start
failed with result 'dependency'.
Aug 06 16:26:09 xubuntu systemd[1]: dev-sdz2.device: Job dev-sdz2.device/start
failed with result 'timeout'.
Aug 06 16:26:09 xubuntu systemd[1]: mnt-test.automount: Got automount request
for /mnt/test, triggered by 3644 (gmain)
...

The same occurs for an autofs CIFS mount that is only accessible over a VPN.
When the VPN is not available journalctl shows Thunar repeatedly trying to
access it when it is added as a GTK3 bookmark in Places.

>From /etc/fstab:

//S1023760.slbs.local/Data$ /mnt/SLBS/Data cifs
noauto,_netdev,uid=1000,gid=1000,credentials=/home/tj/.config/SLBS.cifs.creds,x-systemd.automount,x-systemd.idle-timeout=120,x-systemd.device-timeout=2

$ systemctl cat mnt-SLBS-Data.{,auto}mount
# /run/systemd/generator/mnt-SLBS-Data.mount
# Automatically generated by systemd-fstab-generator

[Unit]
SourcePath=/etc/fstab
Documentation=man:fstab(5) man:systemd-fstab-generator(8)

[Mount]
Where=/mnt/SLBS/Data
What=//S1023760.slbs.local/Data$
Type=cifs
Options=noauto,_netdev,uid=1000,gid=1000,credentials=/home/tj/.config/SLBS.cifs.creds,x-systemd.automount,x-systemd.idle-timeout=120

# /run/systemd/generator/mnt-SLBS-Data.automount
# Automatically generated by systemd-fstab-generator

[Unit]
SourcePath=/etc/fstab
Documentation=man:fstab(5) man:systemd-fstab-generator(8)
Before=remote-fs.target

[Automount]
Where=/mnt/SLBS/Data
TimeoutIdleSec=2min

-- 
You are receiving this mail because:
You are the assignee for the bug.