[Xfce-bugs] review requested: [Bug 15771] Locations with midnight sun erroneously display the nighttime icon : [Attachment 8839] Fix for polar regions

[bugzilla-daemon at xfce.org]

Goran <tiny.lasagna at protonmail.com> has asked  for review:
Bug 15771: Locations with midnight sun erroneously display the nighttime icon
https://bugzilla.xfce.org/show_bug.cgi?id=15771

Attachment 8839: Fix for polar regions
https://bugzilla.xfce.org/attachment.cgi?id=8839&action=edit



--- Comment #1 from Goran <tiny.lasagna at protonmail.com> ---
Created attachment 8839
  --> https://bugzilla.xfce.org/attachment.cgi?id=8839&action=edit
Fix for polar regions

This patch fixes the issue by adding the elevation of the 'solarnoon' and
'solarmidnight' parameters, which, unlike sunrise and sunset times, are
guaranteed to be available by the current sunrise API, as well as adds separate
formatting for transition periods (polar day -> regular and so on).
Note that due to bug 15308, the displayed icon may not be the correct one,
despite the sunrise/sunset times being correct.