[Xfce-bugs] review requested: [Bug 15308] Panel weather icons do not correspond to the correct timezone : [Attachment 8836] Patch for parsing of sunrise API data

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Fri Aug 2 16:17:02 CEST 2019


Goran <tiny.lasagna at protonmail.com> has asked  for review:
Bug 15308: Panel weather icons do not correspond to the correct timezone
https://bugzilla.xfce.org/show_bug.cgi?id=15308

Attachment 8836: Patch for parsing of sunrise API data
https://bugzilla.xfce.org/attachment.cgi?id=8836&action=edit



--- Comment #4 from Goran <tiny.lasagna at protonmail.com> ---
Created attachment 8836
  --> https://bugzilla.xfce.org/attachment.cgi?id=8836&action=edit
Patch for parsing of sunrise API data

I think this patch should fix it, the times from the sunrise API seemed to have
been converted to UTC, but not back to localtime for the call to is_night_time,
which then determines the icon.
I've verified that the astro->sunrise/sunset times are now actual local times,
but I'm not sure if the patch screws up anything else (such as the cache), it'd
be great if someone could test it.


More information about the Xfce-bugs mailing list