[Xfce-bugs] [Bug 14722] Better shutdown fallback code for the BSDs

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=14722

--- Comment #20 from Landry Breuil <landry at xfce.org> ---
I've looked again at ali's branch, and i see that autospawning ckit (if
installed but not launched, because messagebus doesnt run or the session hasnt
been lauched within ckit) has been disabled by
G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START in
https://git.xfce.org/users/ali/xfce4-session/commit/?h=bsd-shutdown-fallback&id=b7fab5309f40979da56c29bc649f1d16e625a16c
and that makes sense, as starting a ckit daemon from the session will only lead
to issues, as a running session cannot be 'reparented' later on to a ckit
launched after the session.

so besides the nit on _SC_NGROUPS_MAX/MAX_USER_GROUPS (maybe using int new_grp
= sysconf(_SC_NGROUPS_MAX) in
https://git.xfce.org/users/ali/xfce4-session/tree/xfce4-session/xfsm-shutdown-fallback.c?h=bsd-shutdown-fallback#n210
and remove the #define), i think this should be merged so that its properly
tested for 4.14. Otherwise that'll miss it...

olivier, guido, more opinions ?

-- 
You are receiving this mail because:
You are the assignee for the bug.