[Xfce-bugs] [Bug 10089] Suspend + lock screen works a bit insecure

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Sat Sep 15 00:17:29 CEST 2018


https://bugzilla.xfce.org/show_bug.cgi?id=10089

--- Comment #7 from Jarno Suni <8 at iki.fi> ---
The bug is in xfce4-session/xfce-screensaver.c (and in
xfce4-session/xfsm-systemd.c before git commit 
9fa8c63b4377bcb46b8471da509ff8bd909c4bf0).

A locker should be called syncronously, not by g_spawn_command_line_async (),
but by g_spawn_command_line_sync () or directly by g_spawn_sync(), and the
provided exit_status should be taken into account.
https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#g-spawn-command-line-sync

I.e. something like this:

gint *exit_status
g_spawn_command_line_sync ("xflock4", NULL, NULL, exit_status, NULL);
if (exit_status != NULL && *exit_status == 0) return TRUE;
return FALSE;

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Xfce-bugs mailing list