[Xfce-bugs] review granted: [Bug 13102] Takes very long to open large directory : [Attachment 7563] Images in the file list are now sorted after the list has been populated

[bugzilla-daemon at xfce.org]

Leiah <SWxsZWdhbE9wY29kZQ at gmail.com> has granted  review:
Bug 13102: Takes very long to open large directory
https://bugzilla.xfce.org/show_bug.cgi?id=13102

Attachment 7563: Images in the file list are now sorted after the list has been
populated
https://bugzilla.xfce.org/attachment.cgi?id=7563&action=edit



--- Comment #4 from Leiah <SWxsZWdhbE9wY29kZQ at gmail.com> ---
Created attachment 7563
  --> https://bugzilla.xfce.org/attachment.cgi?id=7563&action=edit
Images in the file list are now sorted after the list has been populated

I believe this patch fixes the issue of loading large numbers of images when
the program first starts. Instead of sorting the file list as new items are
loaded from the directory, they are prepended, and only sorted (according to
the chosen sort method) once the list is populated.

I've found a directory of 10k items is now loaded in roughly four seconds
regardless of sort method, whereas the same operation varied between 10-30
seconds before the patch, depending on whether the directory was being sorted
by filename or date.