[Xfce-bugs] [Bug 14190] Please keep Thunar Git functional (compilable). TPA Plugin failures!

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=14190

--- Comment #9 from Ali Akcaagac <aliakc at web.de> ---
No, the --prefix=/usr doesn't matter in this particular case.

Though try this:

1) Start from a fresh checkout of Thunar from master...
2) autogen.sh
3) make dist

Run make dist instantly after autogen.sh.

>From what I belive the following may happen:

You may end up in an error saying "thunar-tpa-bindings.c" can't be found.

There is (or may) be a difference if you did this:

1) Start from a fresh checkout of Thunar from master...
2) autogen.sh
3) make
4) make dist

Between step 3 and 4, the thunar-tpa-bindings.c might have been generated from
the thunar-tpa-bindings.xml (if I recall correclty... writing from my memories
right now).

If you issue a make dist right after autogen.sh (the steps listed first), then
make dist may fail, because the thunar-tpa-bindings.c file is NOT YET created.
The target within the Makefile.am probably needs to generate the matching *.c
file first.

My previous comment #2 was only meant to state, that, if you simply enter a
"make", that everything compiles as you said earlier...

But I also need to make clear, that I have Xfce Git installed. So basicly all
libraries, core apps etc. that makes Xfce, is based from Git. So there are no
remaining bits of Xfce 4.12...

---

I am right now checking out a clean Thunar from Git (including your last
cleanings of the Makefile.am)...

Let's redo what I have posted here

First the steps above 1-3 (at the beginning of the comment)

autogen.sh -> works
make dist -> fails

make[3]: *** No rule to make target 'thunar-tpa-bindings.c', needed by
'distdir'.  Stop.

---

Now trying steps 1-4 from aboce (at the middle of the comment). Checking out
again.

autogen.sh -> works
make -> works
make dist -> works

As I thought. The file "thunar-tpa-bindings.c" is generated during the "make"
and therefore "make dist" doesn't complain and generates the Thunar.tar.bz2
release file.

Though It has to be possible to run a "make dist" from a clean Git checkout
right after issuing "autogen.sh && make dist".

I believe, there is a variable missing within the dist part because a "make
dist" also issues a "build" before it generates the Thunar.tar.bz2 release
file.

I only like to mention this, because there are tons of "automated" processes
outside (debian, gentoo, fedora and co.) that rely on generating release files
by issuing only "autogen.sh && make dist".

---

If you look at the thunar-uca plugin, then you see that it also generates a *.c
file from a *.xml file (issuing codegen iirc)... In the Makefile.am you see
that it also has a line saying:

resource_files = $(shell $(GLIB_COMPILE_RESOURCES) --sourcedir=$(srcdir)
--generate-dependencies $(srcdir)/thunar-uca.gresource.xml)

Which also got added to thunar-uca.gresource.c as a variable. I believe that
something like this is missing for the tpa plugin's Makefile.am and therefore
make dist wasn't able to build a dist file without running "make" first. But
running "make" first should not be mandatory acording the autoconf package...

-- 
You are receiving this mail because:
You are the assignee for the bug.