[Xfce-bugs] [Bug 14576] Add support for folder.jpg

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=14576

Andre Miranda <andreldm at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreldm at xfce.org

--- Comment #18 from Andre Miranda <andreldm at xfce.org> ---
Okay, late to the party, I'll to summarize my point of view after a couple of
talks with Alexander:

I like this feature, the way it was proposed is really simple, however since we
are already using gvfs, optionally as a matter of fact, however I dare say the
majority of Thunar users have gvfs installed (I might be very mistaken), thus
probably it's not a good idea to introduce a new standard[1].

Alex's proposal is to use g_file_info_get_attribute_stringv as it's already
used for emblems[2]. Then have an option in the folder's properties dialog to
set/clear the path to an image. Power users could automate this with a script
using gvfs-set-attribute or "gio set". All in all it's still quite simple, easy
for users to discover and interop with Nautilus is a plus.

By the way, I think this should be restricted to folders, it's not wise to
freely change the icon of files, e.g. an executable that looks like a picture.
Anyway, for that we already have .desktop files.

@hyperion, does this approach satisfy your needs? Would you be kind enough to
rework your patch with at least the chuck that reads the image path with
g_file_info_get_attribute_stringv (please)? 

1 - https://xkcd.com/927/
2 - https://git.xfce.org/xfce/thunar/tree/thunar/thunar-file.c#n3366

-- 
You are receiving this mail because:
You are the assignee for the bug.