[Xfce-bugs] [Bug 13881] New: Thunar crashes when leaving a remote folder

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=13881

            Bug ID: 13881
           Summary: Thunar crashes when leaving a remote folder
    Classification: Xfce Core
           Product: Thunar
           Version: 1.6.12
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: major
          Priority: High
         Component: Core
          Assignee: xfce-bugs at xfce.org
          Reporter: andreldm at xfce.org
        QA Contact: nick at xfce.org
                CC: benny at xfce.org, hjudt at xfce.org
  Target Milestone: 1.6.13

Created attachment 7333
  --> https://bugzilla.xfce.org/attachment.cgi?id=7333&action=edit
Patch

I'm experiencing crashes when browsing Windows shared folders, but I've heard
other types of remote folders are also affected.
When a remote folder is accessed, this error is printed:

(thunar:9378): thunar-CRITICAL **: thunar_file_watch: assertion
'(((__extension__ ({ GTypeInstance *__inst = (GTypeInstance*)
((file_watch->monitor)); GType __t = ((g_file_monitor_get_type ())); gboolean
__r; if (!__inst) __r = (0); else if (__inst->g_class &&
__inst->g_class->g_type == __t) __r = (!(0)); else __r =
g_type_check_instance_is_a (__inst, __t); __r; }))))' failed

Upon leaving that folder, Thunar crashes:
thunar:ERROR:thunar-file.c:3929:thunar_file_unwatch: code should not be reached

I found out that a call to g_file_monitor in thunar-file.c:thunar_file_watch
has no error handling, and in the case of remote folders this error happens:
Failed to create file monitor: Operation not supported by backend

So when ThunarFolder is finalized and calls thunar_file_unwatch, its file_watch
will be NULL and _thunar_assert_not_reached kills Thunar.

I was able to put together a fix, but I'm not sure it's the approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.