[Xfce-bugs] [Bug 13953] GIT Master: Thunar doesn't obey --disable-gtk-doc (html, pdf)

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=13953

Andre Miranda <andreldm at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreldm at xfce.org
            Version|unspecified                 |git
   Target Milestone|1.8.0                       |1.6.13

--- Comment #1 from Andre Miranda <andreldm at xfce.org> ---
Passing --disable-gtk-doc to ./autogen.sh or ./configure or just omitting this
option yields:

checking for gtk-doc... yes
checking for gtkdoc-check... gtkdoc-check.test
checking for gtkdoc-check... /usr/bin/gtkdoc-check
checking for gtkdoc-rebase... /usr/bin/gtkdoc-rebase
checking for gtkdoc-mkpdf... /usr/bin/gtkdoc-mkpdf
checking whether to build gtk-doc documentation... no

And no documentation is built nor installed. Only when --enable-gtk-doc is
passed it yields:
checking whether to build gtk-doc documentation... yes

However, if you run make and rerun ./configure --disable-gtk-doc it'll be
ignored, only after make clean --disable-gtk-doc *and* --enable-gtk-doc will be
correctly evaluated again.

Looking at configure.ac.in's history, the gtk-doc support was disabled in 2015
[1] and I recently enabled[2] it after Skunnyk's improvements[3][4] to the docs
generation. The only difference between [1] and [2] is the "Compensate for
broken gtk-doc" part, but I think it's unrelated.

Well, my autotools skills are limited to say if the current behavior is broken
or not, IHMO requiring make clean to disable the docs is not exactly a bug, but
yes, it's a bit confusing.

1 -
https://git.xfce.org/xfce/thunar/commit/?id=d1110b89b3b9553e05329f7293d1b8998894e5ba
2 -
https://git.xfce.org/xfce/thunar/commit/?id=b6ad9271633946bbd64b3969d072f75468e4236a
3 -
https://git.xfce.org/xfce/thunar/commit/?id=a44af0f35ba58a5580cf9efb84d1716369b923f8
4 -
https://git.xfce.org/xfce/thunar/commit/?id=babf85c175e090f59f26b7af7579811687303129

-- 
You are receiving this mail because:
You are the assignee for the bug.