[Xfce-bugs] [Bug 12260] Thunar crash on cut/paste multiple files

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=12260

vc-01 <vlado.chren at inmail.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vlado.chren at inmail.sk

--- Comment #31 from vc-01 <vlado.chren at inmail.sk> ---
Created attachment 6984
  --> https://bugzilla.xfce.org/attachment.cgi?id=6984&action=edit
[FIX] Unreference file object after callback function return

Hello.
I found the core of this issue (and this bug is present also if moving one
file):

thunar-job.c:581
 thunar_file_reload_idle (file);
 g_object_unref (file);

thunar_file_reload_idle() registers routine thunar_file_reload() to be run in
idle. If object unreferencing in second line is run before this registered
function (very likely), assertion for the file object in thunar_file_reload()
fails and thunar crashes. 

I'm sending a patch where unreferencing is done in callback function called
after thunar_file_reload().

Please tell me if any polishing for the patch is needed.

I added new function thunar_file_reload_idle_unref(), other option would be
adding "callback after callback return" argument to thunar_file_reload_idle()
or other approaches.

-- 
You are receiving this mail because:
You are the assignee for the bug.