[Xfce-bugs] [Bug 12715] xfce_dialog_show_error() fails to show text containing ampersand

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=12715

--- Comment #10 from Igor <f2404 at yandex.ru> ---
The patch is almost good, expect for instead of

+      gchar      *escaped_text;
+      /* escape ampersand symbols, etc. (bug #12715) */
+      escaped_text = g_markup_escape_text (primary_text, -1);

it's better to write

+      /* escape ampersand symbols, etc. (bug #12715) */
+      gchar *escaped_text = g_markup_escape_text (primary_text, -1);

in order to avoid "mixed declarations and code" warning.

The patch does not address the case when the text has already been escaped by
the caller - in this case, something like "news:?xt=13415&amv" will be
shown in the dialog. However, I'm not sure whether this can be addressed at
all; and in any case, this is much better than not showing any dialog at all,
like it happens now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.