[Xfce-bugs] review granted: [Bug 12264] Crash when renaming single file in folder : [Attachment 6779] Handle folder change events with file info synchronization

[bugzilla-daemon at xfce.org]

Roy Richardson <rocketx86 at gmail.com> has granted  review:
Bug 12264: Crash when renaming single file in folder
https://bugzilla.xfce.org/show_bug.cgi?id=12264

Attachment 6779: Handle folder change events with file info synchronization
https://bugzilla.xfce.org/attachment.cgi?id=6779&action=edit



--- Comment #109 from Roy Richardson <rocketx86 at gmail.com> ---
Created attachment 6779
  --> https://bugzilla.xfce.org/attachment.cgi?id=6779&action=edit
Handle folder change events with file info synchronization

Here's the latest set of changes that I have been testing which handle folder
change events and synchronize updates to file info by multiple threads.

The patch contains the following changes to address the problems:

1. The file monitor no longer watches for move / rename events. (Harald's
patch)
thunar_file_monitor no longer handles G_FILE_MONITOR_EVENT_MOVED.
thunar_file_monitor_moved has been renamed to thunar_file_renamed which is only
called by thunar_file_rename. 

2. The folder monitor now watches for move events using the newer
G_FILE_MONITOR_WATCH_MOVES flag.
thunar_file_monitor no longer handles G_FILE_MONITOR_EVENT_MOVED.
thunar_file_monitor now handles G_FILE_MONITOR_EVENT_CREATED,
G_FILE_MONITOR_EVENT_MOVED_IN, G_FILE_MONITOR_EVENT_DELETED,
G_FILE_MONITOR_EVENT_MOVED_OUT and G_FILE_MONITOR_EVENT_RENAMED events. 

3. Added thread synchronization around critical sections clearing and reloading
file info by introducing locking on file_info_mutex in
thunar_file_get_async_finish, thunar_file_load and thunar_file_get_with_info.