[Xfce-bugs] [Bug 12282] New: [PATCH] xflock4: Do not override PATH with hardcoded value.

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=12282

            Bug ID: 12282
           Summary: [PATCH] xflock4: Do not override PATH with hardcoded
                    value.
    Classification: Xfce
           Product: Xfce4-session
           Version: Unspecified
          Hardware: Other
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: xfce-bugs at xfce.org
          Reporter: dthompson2 at worcester.edu
        QA Contact: bjt23 at cornell.edu
                CC: benny at xfce.org, nick at xfce.org

Created attachment 6514
  --> https://bugzilla.xfce.org/attachment.cgi?id=6514&action=edit
patch file

xflock4 clobbers the PATH environment variable with a hardcoded value.  /bin
and /usr/bin may be common locations to find binaries on FHS distros, but it is
not always so.  I am a maintainer for the GNU GuixSD project, which does not
conform to the FHS, and we do not have /usr/bin or anything in /bin except
/bin/sh.  So, I think the sanest thing to do in this script is not touch PATH
at all.  It should be properly configured before the xflock4 process is
launched.

I noticed this bug on 4.12.0.  The attached patch is against the current master
branch.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.