[Xfce-bugs] [Bug 12253] New: Intermittent crash on file rename after upgrading to GLib 2.46

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=12253

            Bug ID: 12253
           Summary: Intermittent crash on file rename after upgrading to
                    GLib 2.46
    Classification: Xfce
           Product: Thunar
           Version: 1.6.10
          Hardware: PC (x86_64)
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: Medium
         Component: general
          Assignee: xfce-bugs at xfce.org
          Reporter: evangelos at foutrelis.com
        QA Contact: nick at xfce.org
                CC: benny at xfce.org, hjudt at xfce.org

Created attachment 6476
  --> https://bugzilla.xfce.org/attachment.cgi?id=6476&action=edit
(Not very interesting) backtrace

This is possibly related to bug 11983; however, the crash is reproducible on
current master (a1e737146f79aa2f4497984162ff20c8c7949fb5).

I ran git bisect on glib 2.44.0..2.46.0 and apparently the issue started with
glib commit 779c809a3d07 (inotify: rewrite inotify-kernel). [1]

I've noticed the crash occurring in two possible places in
thunar-file.c:thunar_file_compare_by_name():

4023      /* case insensitive checking */
4024      if (G_LIKELY (!case_sensitive))
4025        result = strcmp (file_a->collate_key_nocase,
file_b->collate_key_nocase);
4026    
4027      /* fall-back to case sensitive */
4028      if (result == 0)
4029        result = strcmp (file_a->collate_key, file_b->collate_key);

I've had instances of crashes at either strcmp() and, weirdly enough, sometimes
none of the arguments are null and other times one or both are null. During one
debugging session, I was able to jump to frame #1 in GDB and do:

(gdb) call strcmp (file_a->collate_key_nocase, file_b->collate_key_nocase)

and the function call didn't result in a segmentation fault, even though GDB
had previously reported that it did.

All in all, I'm not sure what's going here. I suppose it could be a bug in glib
but I failed to produce a crash in nautilus while repeatedly renaming the same
file.

[1] https://git.gnome.org/browse/glib/commit/?id=779c809a3d07

-- 
You are receiving this mail because:
You are the assignee for the bug.