[Xfce-bugs] [Bug 11919] New: xfce4-session-4.10.1-r2 incorrectly closes apps windows at logout/poweroff/reboot

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=11919

            Bug ID: 11919
           Summary: xfce4-session-4.10.1-r2 incorrectly closes apps
                    windows at logout/poweroff/reboot
    Classification: Xfce
           Product: Xfce4-session
           Version: Unspecified
          Hardware: PC (x86_64)
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: xfce-bugs at xfce.org
          Reporter: Ikonta at yandex.ru
        QA Contact: bjt23 at cornell.edu
                CC: benny at xfce.org, nick at xfce.org

I use XFce Desktop Environment on Gentoo GNU/Linux.
Configuration and patches of used build of xfce-base/xfce4-session-4.10.1-r2
package can be seen at
https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/xfce-base/xfce4-session/

The issue is that on closing session XFce uses SIGTERM to terminate GUI
applications.
That is incorrect.

FireFox browser provides the easiest way to see it (so you need previously to
install it, I remember such behaviour since ESR 17, currently I use ESR 31):

First time view normal mode:
1. Start FF;
2. Open some pages (for example https://bugs.gentoo.org/
andhttps://bugzilla.xfce.org/);
3. Normally close window (with two tabs opened) via Ctrl-Q or Alt-F4, or mouse
click on pictogram in window header;
4. Start FF again.
5. You'll see the normal start according to browser settings.

After that we can reproduse the issue:
1. Start FF again (if not started);
2. Open some pages (same as listed or others on your taste);
3. Execute XFce menu's logout (or reboot or poweroff) command (save session
checkbox should be selected);
4. Re-login.
5. FF together with other X11 applications will be saved into session list and
auto-started.
6. But. After FF started, it will show NOT result of ordinar start (seen at 5
step of previous demo), but error tab with broken session list.

The same result you'll get if, after starting FF you'll start terminal, using
ps command get the FF pid and send it SIGTERM signal.

xfce-session should first time try to close window normally (similiarly with
Ctrl-Q and Alt-F4 actions), and only after a control timeout send the rest of
them first SIGTERM and finally SIGKILL signals.
Probably (I'm not familiar with X11 programming) it should be XDestroyWindow
function:
http://www.x.org/releases/X11R7.7/doc/man/man3/XDestroyWindow.3.xhtml

Finally, with the example FF browser: if opened many windows and tabs,
sometimes normal close doesn't fit in default timeout (and XFce echoes
no-responce error window, but some seconds later normal terminate succeed,
destroing also error window.
So it will be fine, if user's sessings will allow to configure value of this
timeout: how much time application should have for normal termination, before
sending SIGTERM signal.

-- 
You are receiving this mail because:
You are the assignee for the bug.