[Xfce-bugs] review granted: [Bug 11817] Slow startup when a folder with many wallpapers is selected : [Attachment 6246] Much faster sorting (without test code)

[bugzilla-daemon at xfce.org]

Igor Kushnir <igorkuo at meta.ua> has granted  review:
Bug 11817: Slow startup when a folder with many wallpapers is selected
https://bugzilla.xfce.org/show_bug.cgi?id=11817

Attachment 6246: Much faster sorting (without test code)
https://bugzilla.xfce.org/attachment.cgi?id=6246&action=edit



--- Comment #16 from Igor Kushnir <igorkuo at meta.ua> ---
Created attachment 6246
  --> https://bugzilla.xfce.org/attachment.cgi?id=6246&action=edit
Much faster sorting (without test code)

In this patch I cache collation keys and this dramatically improves
performance: from 1.54 to 0.51 seconds for 6192 images with Random Order off.
This time I verified that the sorting function works correctly (it passes my
tests). Pick one of the 2 attached patches depending on whether the test code
in one of them makes sense.